[codex] update Playwright e2e runner and improve speed to completion#1829
Merged
Conversation
e7bb5fb to
3d1d779
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the e2e runner to the latest Playwright release and keeps the GitHub Actions browser environment aligned with it.
It also makes the PR e2e workflow less likely to block indefinitely by canceling stale runs, adding job/step time limits, and running inside the official Playwright container instead of installing Linux browser dependencies on every run.
Why
Recent PR e2e runs were sometimes getting stuck before tests started, specifically during the Playwright browser setup step. Moving to the Playwright container and adding explicit limits should make normal runs faster to start and prevent stuck setup from consuming hours.
The first containerized CI run exposed one extra environment prerequisite:
oven-sh/setup-bunneedsunzip, which the Playwright image does not include by default. This PR now installs that small prerequisite before setting up Bun.Changes
@playwright/testto1.60.0inpackage.jsonandbun.lock.mcr.microsoft.com/playwright:v1.60.0-noble.unzipbeforeoven-sh/setup-buninside the Playwright container.playwright install --with-deps chromiumwith a short browser verification step, since the container already includes the browser dependencies.Validation
npm view @playwright/test dist-tags.latest versionconfirmed1.60.0.mcr.microsoft.com/playwright:v1.60.0-nobleimage exists for Linux runners.bun install --frozen-lockfilebunx playwright --version->1.60.0bunx playwright install chromiumbunx playwright test --list->44 tests40 passedbun run type-checkCI=1 bun run test:e2e->41 passed, 3 skippedbun lintgit diff --check