🐛 Fix: set right duration when dragging up outside maingrid view #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is debatable, but I personally think displaying a browser alert, while being helpful to us, is not UX friendly not professional to display to end user. This commit conditionally displays the alert message ony in development mode
…in grid view The culprit was the deleted lines. I tested the deleted changes as thoroughly as possible and detected no noticable UX change. I am confused on why we needed these deleted lines, but as of now I don't see any need for them.
that-one-arab
deleted the
bug_set_right_duration_when_dragging_up_outside_maingrid_view
branch
Contributor
Author
|
Checks didn't pass to due changes introduced in #302 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR originally created in #307
Closes #266
The culprit was the deleted lines. I tested the deleted changes as thoroughly as possible and detected no noticable UX change. I am confused on why we needed these deleted lines, but as of now I don't see any need for them.
Videos
Before
Peek.2025-03-17.21-16.webm
After
Peek.2025-03-17.21-14.webm