🐛 Fix: Implement hotfix to address events start of week date filter not being returned consistently#471
Conversation
|
@tyler-dane I realize a test is failing, I'll be sure to address it, but I want to know your thoughts about this approach |
|
I'm good with this approach. Wondering how it'll work if there are events on Saturday, though. Would those show up on Sunday now? As long as weird bugs like that aren't introduced and the tests pass, I think we can merge this one |
|
@tyler-dane I did smoke test it and it looked fine. Will continue testing and fix failing tests on sunday. |
Test was failing due to mock event's start-end date being outdated. Since we now introduce a manual filtering layer in the get events pipeline, we need to ensure that expect statements validated against mock events have correct start-end date range
|
@tyler-dane Fixed failing tests and added videos to better show results. LMK your thoughts. |
|
@tyler-dane I guess you missed my notification. i'm going ahead with the merge for now. |
that-one-arab
deleted the
bug_fix_allday_events_not_returned_when_filtered
branch
|
Looks good. Deployed to prod and seems to be working fine, thanks for finding a creative solution here and seeing it through. @that-one-arab |
2 participants
Closes #428
This hotfix resolves the issue by adjusting start date to be 1 day before the actual start date, this allows us to extend our date range to cover additional events that may not be returned. We ensure that the returned events match the initial date range by manually filtering them.