Skip to content

✨ Feat(web): better UI for migrate event buttons#574

Merged
that-one-arab merged 5 commits intomainfrom
feat/526-better-ui-for-migrate-event-buttons
Jul 7, 2025
Merged

✨ Feat(web): better UI for migrate event buttons#574
that-one-arab merged 5 commits intomainfrom
feat/526-better-ui-for-migrate-event-buttons

Conversation

@that-one-arab
Copy link
Contributor

@that-one-arab that-one-arab commented Jun 30, 2025

Description

Closes #526

  • use the right arrow and left icons from phosphoricons
  • capitalize CTRL. This is to keep our casing consistent (We already have SHIFT in another shortcut)
  • Add slight margins between icons and title field.

things were looking a little too tight after we changed migrate buttons icons to phosphoricons
helps with making sure the tests pass since some tests depends on querying the id of the element
… consistent with migrate buttons in someday event form
@that-one-arab
Copy link
Contributor Author

@tyler-dane I know you only mentioned updating the right arrow but I took the liberty of updating the left arrow too in someday event form and grid event form (move to sidebar button)

I also updated them for someday event rectangle but the new UI was sort of 'eh', LMK your thoughts on it and whether we should keep it

image

@that-one-arab that-one-arab requested a review from tyler-dane June 30, 2025 02:30
@tyler-dane
Copy link
Contributor

tyler-dane commented Jul 3, 2025

@that-one-arab I think I was unclear in the original issue about what I was asking for.

Arrow icon
You only need to use the arrow icon in the tooltip. The buttons at the top of the event form should say < and >

Here's a proof-of-concept for what the tooltip should look like.
Screenshot 2025-07-03 at 6 03 30 AM

Notice how the arrow icon is only used for the tooltip. This is because the arrow icon is meant to signify the arrow key (as opposed to the < key).

Tooltip text
Notice how the tooltip text does not say "Migrate Backward." We shouldn't use "migrate backward," because that implies that it's going back one week, rather than going to the sidebar.

If "Migrate to Sidebar" takes up too much space, you could use "To Sidebar" instead

Event Rectangle Icons

These should stay < and >.

These symbols are references to those in the bullet journal migration method, so I'd like to keep them. They're also cleaner than the arrow icons IMO.

https://bulletjournal.com/pages/migration?srsltid=AfmBOooVa0PuwOB-gqv1DYcRFN9Dr1t15_UJBec1qv3yf50yGHBCHkn9

https://bulletjournal.com/blogs/faq/migration?srsltid=AfmBOopAWI4eDXQMmQE0yy6dWp3bQUtO26u0tjOykFtYWOj-FKvIH4Bh

@that-one-arab that-one-arab merged commit 85b6d03 into main Jul 7, 2025
4 checks passed
@that-one-arab that-one-arab deleted the feat/526-better-ui-for-migrate-event-buttons branch July 7, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add shortcuts to migrate someday event buttons

2 participants

Comments