Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Fixes the singular/plural "bug" with s!pay#1088

Merged
Doges merged 1 commit intodevfrom
grammar-fix-pay-command
Jan 25, 2020
Merged

Fixes the singular/plural "bug" with s!pay#1088
Doges merged 1 commit intodevfrom
grammar-fix-pay-command

Conversation

@dsgpaiva
Copy link
Copy Markdown
Member

@dsgpaiva dsgpaiva commented Jan 20, 2020

@dsgpaiva dsgpaiva requested a review from a team January 20, 2020 08:56
@dsgpaiva dsgpaiva self-assigned this Jan 20, 2020
@github-actions github-actions Bot added the scope: commands New command(s) suggestion/addition label Jan 20, 2020
Doges
Doges approved these changes Jan 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Doges Doges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fersilva16
Copy link
Copy Markdown
Contributor

fersilva16 commented Jan 20, 2020

Why uses a type param? With i18next u can do it with "count" param.

docs: https://www.i18next.com/translation-function/plurals

@dsgpaiva
Copy link
Copy Markdown
Member Author

dsgpaiva commented Jan 21, 2020

Why uses a type param? With i18next u can do it with "count" param.

docs: i18next.com/translation-function/plurals

will fix on my OS classes

@metehus
Copy link
Copy Markdown
Member

metehus commented Jan 24, 2020

how do i approve

metehus
metehus approved these changes Jan 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@metehus metehus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Doges Doges merged commit 511cbff into dev Jan 25, 2020
@Doges Doges deleted the grammar-fix-pay-command branch January 25, 2020 01:52
@Doges
Copy link
Copy Markdown
Member

Doges commented Jan 25, 2020

Why uses a type param? With i18next u can do it with "count" param.

docs: https://www.i18next.com/translation-function/plurals

btw, you need to open a new pr anyway

This was referenced Mar 12, 2020
Open
Open
This was referenced Dec 11, 2020
Open
Open
This was referenced Aug 4, 2021
Open
Open
This was referenced Aug 11, 2021
Open
Open
This was referenced Sep 2, 2021
Open
Open
This was referenced Mar 23, 2022
Open
Open
@dsgpaiva dsgpaiva mentioned this pull request May 13, 2022
Open
@LogGame-HU-DEaN LogGame-HU-DEaN mentioned this pull request May 14, 2022
Open
This was referenced Oct 18, 2022
Open
Open
@LogGame-HU-DEaN LogGame-HU-DEaN mentioned this pull request Jan 9, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedrofracassi pedrofracassi Awaiting requested review from pedrofracassi

@davipatury davipatury Awaiting requested review from davipatury

@fersilva16 fersilva16 Awaiting requested review from fersilva16

2 more reviewers

@metehus metehus metehus approved these changes

@Doges Doges Doges approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgpaiva dsgpaiva

Labels

scope: commands New command(s) suggestion/addition scope: translation Translation related stuff status: waiting-for-review type: fix Fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

grammatical problem with pay command

4 participants

@dsgpaiva @fersilva16 @metehus @Doges