Skip to content
This repository was archived by the owner on Mar 31, 2025. It is now read-only.

allow injection of custom object mapper#15

Merged
stritti merged 94 commits intomasterfrom
unknown repository
Apr 28, 2017
Merged

allow injection of custom object mapper#15
stritti merged 94 commits intomasterfrom
unknown repository

Conversation

@kobisuissa
Copy link
Copy Markdown

No description provided.

fzr and others added 30 commits March 24, 2017 12:45
Added Test Specific Files, New Class Delete to handle Delete Responses, Implemented Method in Table, Added Attributes to Actor Class
Implemented Test files, Implemente Method to create, implemented new Class Post Record to generate the Body for the request
- timeout could be set now
-Added Serialized Names in Movie and Actor
-Added Testfiles for MovieCreation
-Implemented Check for id and created Time
-Added additional Tests
-Serialized Name in Movie
-Check if If or Created Time or Id are set
@kobisuissa
Copy link
Copy Markdown
Author

@stritti could you please have a look at the PR checker job? does it set the required AIRTABLE_API_KEY variable? I merely added one test (and tested it locally), doesn't make sense that I broke all tests... Thanks!

@Zelle97
Copy link
Copy Markdown
Contributor

Zelle97 commented Apr 19, 2017

Hello kobisuissa thank you for your PR!

The Travis CI removed the environment variables for security reasons.
Just found this in the doc: https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

I'm working on a fix for this, please be patient. Thanks!

@stritti
Copy link
Copy Markdown
Member

stritti commented Apr 27, 2017

@kobisuissa many thanks for your PR. @Zelle97 now has separated the integration tests from common unit tests.
The integration tests are not run by travis on PRs now any more. Only the unit tests which are independent from the env variables.

@stritti
Copy link
Copy Markdown
Member

stritti commented Apr 27, 2017

@kobisuissa could you update your PR for the new structure, please?

kobisuissa added 4 commits April 27, 2017 19:25
…to feature/allow-object-mapper-injection

# Conflicts:
#	.travis.yml
#	build.gradle
#	src/main/java/com/sybit/airtable/Airtable.java
…ction' into feature/allow-object-mapper-injection

# Conflicts:
#	.travis.yml
#	build.gradle
#	src/main/java/com/sybit/airtable/Airtable.java
…to feature/allow-object-mapper-injection

# Conflicts:
#	.travis.yml
#	build.gradle
#	src/main/java/com/sybit/airtable/Airtable.java
…to feature/allow-object-mapper-injection

# Conflicts:
#	.travis.yml
#	build.gradle
#	src/main/java/com/sybit/airtable/Airtable.java
@stritti stritti merged commit 86de3f4 into Sybit-Education:master Apr 28, 2017
@stritti
Copy link
Copy Markdown
Member

stritti commented Apr 28, 2017

Thank you very much @kobisuissa for your enhancement.

@kobisuissa
Copy link
Copy Markdown
Author

my pleasure @stritti do you have automatic deployment to bintray upon merge to master?

@stritti
Copy link
Copy Markdown
Member

stritti commented Apr 28, 2017

similar: I have to create a version tag :)

@stritti
Copy link
Copy Markdown
Member

stritti commented Apr 28, 2017

https://bintray.com/sybit-education/maven/airtable.java/0.1.3.n

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants