Skip to content

Update order address if changed during completion#65

Merged
Zales0123 merged 6 commits intoSylius:masterfrom
SirDomin:webhook-complete-order
Aug 31, 2020
Merged

Update order address if changed during completion#65
Zales0123 merged 6 commits intoSylius:masterfrom
SirDomin:webhook-complete-order

Conversation

@SirDomin
Copy link
Contributor

@SirDomin SirDomin commented Aug 25, 2020

As webhooks arent working yet, it changes address when completing the order

@SirDomin SirDomin self-assigned this Aug 25, 2020
Copy link
Contributor

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be changed to handling new shipping address on synchronous CompleteOrder request 🖖

Copy link
Contributor

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the PR title is no longer valid 🖖

@Zales0123 Zales0123 changed the title Webhook complete order Update order address if changed during completion Aug 31, 2020
@Zales0123 Zales0123 merged commit eca96f1 into Sylius:master Aug 31, 2020
@Zales0123
Copy link
Contributor

Thanks, @SirDomin! 🥇

@Zales0123 Zales0123 deleted the webhook-complete-order branch August 31, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants