Fixes tests/Application .gitignore#146
Merged
Zales0123 merged 1 commit intoSylius:1.3from Nov 28, 2018
Merged
Conversation
Contributor
|
Seems like a fair solution 👍 Could you also remove this line from Travis configuration? And I believe it should be opened to branch |
Contributor
|
Ok, seems that it won't be so easy, as I thought and we should probably incorporate these changes to |
Contributor
Author
|
Yes I tested it on 1.3 only. I’ll remove that line tomorrow morning. |
Contributor
Author
|
Hi @Zales0123, |
The `tests/Application/public/media/image/.gitignore` file has been probably added to the index with a force add (`git add -f`) because the parent `.gitignore` file (the one in `tests/Application`) doesn't properly de-ignore it. So when someone creates a new plugin from this skeleton the `tests/Application/public/media/image/.gitignore` file is not added to index and the build fails (the `tests/Application/public/media/image/` must exists) otherwise you'll get the error: ``` [Liip\ImagineBundle\Exception\InvalidArgumentException] Root image path not resolvable ... ```
Zales0123
approved these changes
Nov 28, 2018
Contributor
|
Thank you, Manuele! 🎉 |
Contributor
|
Feel welcomed to open a similar PR to |
Contributor
Author
|
Ok will be done. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tests/Application/public/media/image/.gitignorefile has been probably added to the index with a force add (git add -f) because the parent.gitignorefile (the one intests/Application) doesn't properly de-ignore it.So when someone creates a new plugin from this skeleton the
tests/Application/public/media/image/.gitignorefile is not added to index and the build fails (thetests/Application/public/media/image/must exists) otherwise you'll get the error: