Mention default_bus configuration in installation process#103
Merged
bartoszpietrzak1994 merged 1 commit intoSylius:masterfrom Nov 20, 2018
Conversation
Zales0123
added
Bug
bartoszpietrzak1994
approved these changes
Nov 20, 2018
Zales0123
deleted the
mention-default-bus-configuration-in-installation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100.
The only thing that worries me, is that it still would throw an exception after SymfonyFlex configuration if there is no default_bus configured (during cache:clear).
The best solution would be to run some script after configuration and before clearing cache asking "Which command bus you want to setup as default?".
But right now it's better than it was :)