Merged
Conversation
Zales0123
added
Enhancement
pamil
reviewed
Oct 5, 2018
Zales0123
force-pushed
the
switch-to-symfony-messenger
branch
5 times, most recently
from
fa4d450 to
77dcf2f
Compare
Zales0123
force-pushed
the
switch-to-symfony-messenger
branch
from
77dcf2f to
814af0b
Compare
Zales0123
force-pushed
the
switch-to-symfony-messenger
branch
from
814af0b to
b5ce796
Compare
pamil
suggested changes
Oct 31, 2018
src/Resources/config/app/config.yml
Outdated
| sylius_refund_event_bus: ~ | ||
| framework: | ||
| messenger: | ||
| default_bus: sylius_refund_plugin.command_bus |
Contributor
There was a problem hiding this comment.
I copy-pasted it into similar PR in InvoicingPlugin, but I think we shouldn't set the default bus for the whole application here.
Contributor
Author
There was a problem hiding this comment.
I've defined the default bus only for the test env. After all, we need this configuration only to be able to inject command bus to Behat contexts. This way it will be possible and also it won't be configured for the whole application 🐃
pamil
approved these changes
Nov 2, 2018
Contributor
|
Thank you, Mateusz! 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Prooph service bus has been deprecated it's a good time to switch to a new, shiny Symfony Messenger Component.