#65 Fix for partial refund of shipping fees#94
Merged
Zales0123 merged 3 commits intoSylius:masterfrom Nov 2, 2018
Merged
Conversation
laurent35240
force-pushed
the
65_fix_partial_refund_shipping
branch
from
a971f01 to
8932a91
Compare
Zales0123
reviewed
Oct 29, 2018
Contributor
Zales0123
left a comment
Zales0123
left a comment
There was a problem hiding this comment.
Thank you for this fix Laurent! To fix it, we need two more things:
ShipmentCreditMemoGeneratorSpecadjusted (we need to check one more exception throw)- new scenario in
having_credit_memo_generated.featurefor partial shipment refund credit memo
Do you think you'll be able to do that? One more time, thank you for the contribution!
Contributor
Author
|
Sure I will try to add this |
Code refacto
Contributor
Author
|
I managed to do refacto and add phpSpec test but I am stuck for the moment with behat. |
laurent35240
force-pushed
the
65_fix_partial_refund_shipping
branch
from
88e674b to
b871b52
Compare
Contributor
Author
|
@Zales0123 Behat test added. All clear for final code review 😉 |
Zales0123
approved these changes
Nov 2, 2018
Contributor
Zales0123
left a comment
Zales0123
left a comment
There was a problem hiding this comment.
Two small issues that can be fixed in a separate PR :)
| And it should be issued in "United States" channel | ||
| And its total should be "$5.50" | ||
|
|
||
|
|
| And the customer bought 2 "Mr. Meeseeks T-Shirt" products | ||
| And the customer chose "Galaxy Post" shipping method to "United States" with "Space money" payment | ||
| And the order "#00000023" is already paid | ||
| And I am logged in as an administrator |
Contributor
There was a problem hiding this comment.
I would move this one to the end of the Background
Contributor
|
Seems nice, thank you, Laurent, for this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #65