fix(web): logo no longer triggers full-page navigation#80
Merged
Conversation
Change icon-rail logo from <a href="/"> to <button>. Click did a full reload to /, blowing away current thread/scroll/draft state. Now the logo is inert (clicking does nothing); future PR can wire it to soft-route home if desired.
🤖 bot-review (comment-only · phase 1)Diff: Red-line checks:
Needs human review — these paths are not eligible for future auto-approve:
Phase 1: this bot leaves comments only. Auto-approve will be enabled per-path after 1–2 weeks of clean runs. Promotion plan: judy PR #42 follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logo was a
<a href="/">, so clicking it did a full page reload and wiped current thread / scroll / draft state.Change it to a plain
<button>(no default navigation). Click is now inert — no reload, no state loss. Style adjusted so the button matches the previous logo cell visually.Future follow-up if we want it to actually "go home": wire a soft-route on click (e.g.
location.hash = '#/squads').Triggered by scott in OpenForge thread th_19eb68d8bf4_a8e407.