feat: add non-mutating set_scalar_constants#165
Open
MilesCranmerBot wants to merge 1 commit intoSymbolicML:masterfrom
Open
feat: add non-mutating set_scalar_constants#165MilesCranmerBot wants to merge 1 commit intoSymbolicML:masterfrom
MilesCranmerBot wants to merge 1 commit intoSymbolicML:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 59.33% 59.53% +0.20%
==========================================
Files 30 30
Lines 2673 2684 +11
==========================================
+ Hits 1586 1598 +12
+ Misses 1087 1086 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f18c3ac to
141ecab
Compare
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a non-mutating
set_scalar_constantshelper that returns a new tree with updated scalar constants.Motivation (empirical): trying to run
ForwardDiff.gradientthroughset_scalar_constants!on aNode{Float64}fails because constant node fields are concretely typed (e.g. cannot assignDualintoFloat64). The new helper promotes the tree number type to accommodateeltype(constants)(so Duals work), sets the constants, and returns the new tree.Changes:
set_scalar_constants(tree, constants)(non-mutating; promotes number type if needed).set_scalar_constants(ex::Expression, constants)wrapper.Tests:
Pkg.test()