Ensured exception message regex matching keeps working with PHPUnit >=4.3.0 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Build seems to fail for PHPUnit 3.7. Will fix. |
Collaborator
|
Thanks @fvdb , I will look into this soon and then merge it! |
Collaborator
|
Thanks for looking into this issue @fvdb. I think that instead of checking the actual version of PHPUnit, it would be just fine to check if that RegExp class exists. That way, when a new version suddenly doesn't have the class anymore, we won't need to modify the |
Contributor
Author
|
Sounds good. Made the change. |
Contributor
Author
|
Did a rebase to clean up the commit history. |
matthiasnoback
added a commit
that referenced
this pull request
Oct 12, 2014
Ensured exception message regex matching keeps working with PHPUnit >=4.3.0
Collaborator
|
Thanks! Merged and tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before PHPUnit 4.3.0, you could use PHPUnit_Framework_Constraint_ExceptionMessage to match an exception message using either a sub string, or a regular expression. Support for this was removed in this commit: sebastianbergmann/phpunit@eee0584
This means that if you use regular expressions to match invalid configuration exception messages, you need to change those to now use substrings instead.
This PR allows you to simply set an extra parameter "useRegExp" to true, which causes SymfonyConfigTest to instantiate the correct constraint class when using PHPUnit >= 4.3.0. The flag does nothing below 4.3.0, as the existing constraint class will support regular expressions just fine.