Advocate adding the package to require-dev #2
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasnoback
added a commit
that referenced
this pull request
Nov 4, 2013
Advocate adding the package to require-dev
Collaborator
|
Thanks Wouter, that's a very good suggestion. |
Contributor
Author
|
you're welcome :) Fyi, I'm looking for integrating this into the CMF Testing component. |
Collaborator
|
Ah, that's great! Did you also look at https://github.com/matthiasnoback/SymfonyDependencyInjectionTest? |
Contributor
Author
|
Yes, I did. But it has a low priority, testing the config (mainly the xml support) has a higher priority |
Collaborator
|
Right, hope you like it - let me know if anything doesn't work for you. |
|
@wouterj what do you mean to test the xml? |
Contributor
Author
|
@cordoval XML support. For instance, fixXmlConfig, special beforeNormalization rules, etc. For an example, see symfony-cmf/routing-auto-bundle#35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.