Skip to content

fix AbstractCompilerPassTestCase when using strict-mode #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2014
Merged

fix AbstractCompilerPassTestCase when using strict-mode #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions PhpUnit/AbstractCompilerPassTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ public function compilation_should_not_fail_with_empty_container()
{
try {
$this->compile();

// Ensure assertion for strict mode
$this->assertFalse($this->container->has('no_service'));
} catch (\Exception $e) {
$this->fail('The compiler pass should not fail with an empty container.');
}
Expand Down
2 changes: 1 addition & 1 deletion phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit bootstrap="./vendor/autoload.php" colors="true">
<phpunit bootstrap="./vendor/autoload.php" colors="true" strict="true">
<testsuites>
<testsuite>
<directory suffix="Test.php">./Tests</directory>
Expand Down