Merged
Conversation
Contributor
Author
|
Closes #932 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “Visualization” viewing section and wires it into the side panel/page rendering flow for ComponentDefinition and ModuleDefinition pages.
Changes:
- Insert “Visualization” into the section order for ComponentDefinition/ModuleDefinition in the side panel.
- Add a new
Visualizationsection that fetches visualization HTML and renders it in an iframe. - Update plugin/section imports and route “Visualization” page rendering through
GenericContent.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| frontend/components/Viewing/SidePanel.js | Prepends “Visualization” into the section order for relevant types. |
| frontend/components/Viewing/Sections/Visualization.js | New visualization section: fetches visualization content and renders via iframe/srcDoc with resize/navigation handling. |
| frontend/components/Viewing/Sections/Plugin.js | Fixes import paths and refactors HTML parser options placement. |
| frontend/components/Viewing/PageJSON/Rendering/GenericContent.js | Updates Plugin import path and adds rendering branch for “Visualization”. |
Comments suppressed due to low confidence (1)
frontend/components/Viewing/Sections/Plugin.js:236
optionsis defined at module scope but referencesproperties(e.g.,properties.plugin.name), which is only defined inside thePlugincomponent. This will throw aReferenceErrorat runtime. MoveoptionsinsidePlugin, or make it a factory that takes the needed values (e.g.,pluginName) and returns the options object so it doesn’t rely on out-of-scope variables.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/components/Viewing/PageJSON/Rendering/GenericContent.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cjmyers
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #932