[CORE-1509] Merge parse2syncano with syncano-cli#9
Conversation
|
@forgems pls take a look :) |
|
|
||
| :: | ||
|
|
||
| syncanocli login |
There was a problem hiding this comment.
Why have you renamed command to syncanocli instead of just syncano ?
There was a problem hiding this comment.
You think just syncano is enough? I caaaan revert it - no problem :)
There was a problem hiding this comment.
As far as I remember from sprint planning, we were talking about 'syncano' name :)
| CONFIG_VARIABLES_NAMES = ['PARSE_MASTER_KEY', 'PARSE_APPLICATION_ID', 'SYNCANO_APIROOT', | ||
| 'SYNCANO_ADMIN_API_KEY', 'SYNCANO_INSTANCE_NAME'] | ||
|
|
||
| PARSE_APPLICATION_ID = os.getenv('P2S_PARSE_APPLICATION_ID', '') |
There was a problem hiding this comment.
Remove P2S_ prefixes from these environement variables.
|
@forgems Could pls take a look in new commands management? |
|
IMHO it's overkill, and time to move to something that is already used by other projects, has good documentation and is tested. It will also lower entry barrier for new developers. Something like http://docopt.org/ (docker-compose uses it) or http://click.pocoo.org/5/. We shouldn't focus on command line parsing but on defining functionalities. I did this with 2 functions because I knew argparse before, and I didn't need any fancy functionality. IMHO use of metaclasses is reserved for libraries and frameworks, not CLI tools ;) |
|
@forgems gonna merge this :) And think in next sprint about change the argparse with another tool. Also will redesign one more time new command process adding. |
2 participants
No description provided.