Fix codegen for end-of-scope stores#215
Open
newmattock wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96.
This updates local-variable lookup for store instructions so codegen can handle stores whose local-variable table entry starts at the store PC, and can synthesize a scoped local when javac omits metadata for an unused zero-length local at the end of a scope.
The ignored
ArbitraryScopeTestcodegen regression is re-enabled. Its expected output now uses the generated slot name for the compiler-erased unused local, since the original source name is not available in the class metadata.Validation:
git diff --checkjavac --release 8JUnitCore com.aparapi.codegen.test.NullCheckTest com.aparapi.codegen.test.ArbitraryScopeTest-> OK (4 tests)Note: I did not add payment details.