Option to remove the NOTICE message upon joining a server

[ruruchiii]

I have a very small qualm but it'd be nice if there was a server side option to disable the persistence notice. It interferes with the MOTD due to appearing right below it.

The notice in question is this one :

NOTICE: This server uses persistent rooms, which means that the playlist information is stored between playback sessions. If you want to create a room where information is not saved then put -temp at the end of the room name.

Related PR: c0e8652

[dnomd343]

Related logic:

syncplay/syncplay/protocols.py

Lines 143 to 146 in b96d43a

	if self.persistentRoomWarning(featureList):
	if len(motd) > 0:
	motd += "\n\n"
	motd += getMessage("persistent-rooms-notice")

syncplay/syncplay/protocols.py

Lines 558 to 561 in b96d43a

	if self.persistentRoomWarning(clientFeatures=self._features, serverFeatures=hello["features"]):
	if len(hello["motd"]) > 0:
	hello["motd"] += "\n\n"
	hello["motd"] += getMessage("persistent-rooms-notice")

[Et0h]

Removal seems like quite a severe option. I just tried connecting to a server with the message using Syncplay 1.7.5 development build (which uses the new code text format) and it looks fine to me. Maybe you could provide a screenshot using that build and annotate it to show what you find objectionable so we can look into whether the behaviour can be tweaked to retain the message but display it in a way which does not interfere with your vision of an ideal MOTD. For example, would showing the message above rather than below the MOTD solve the problem?

[ruruchiii]

I don't necessarily think there's an "ideal" version since some might want the notice to be more obvious than the MOTD, though one could also add the information to the MOTD themselves if it's that important to them. I guess the notice could be the default message if no MOTD is manually set, though that seems a bit complicated for such a small feature.

Personally for me moving it above the MOTD would be fine.

[Et0h]

The MOTD has been moved, so closing for now as it resolves the original issue. If someone has a problem with the new change then they are free to propose a PR which puts the message outside the MOTD styling.