Conversation
ddbaptiste
requested changes
Apr 12, 2024
Member
ddbaptiste
left a comment
ddbaptiste
left a comment
There was a problem hiding this comment.
There are a lot of ideas that I like in this.
I'm requesting changes to parse(), detailed in comments in-context.
I also want to say that I don't like that Config::get() requires a default_value argument. It's nearly equivalent to using ptree's templated get(). As get() is used when an input parameter is required, it should fail (i.e. error) if there is no specified value, so the user knows that there was an issue with their input.
ddbaptiste
requested changes
Apr 15, 2024
Member
ddbaptiste
left a comment
ddbaptiste
left a comment
There was a problem hiding this comment.
Just one more small change requested in this review.
ddbaptiste
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is breaking out the interfaces (specifically Config). It should theoretically explain what I'm thinking with OO design?