Skip to content

CI#67

Merged
MJC598 merged 20 commits intomainfrom
ci
Feb 12, 2025
Merged

CI#67
MJC598 merged 20 commits intomainfrom
ci

Conversation

@MJC598
Copy link
Copy Markdown
Contributor

@MJC598 MJC598 commented Oct 2, 2024

Updating workflow for unit tests and adding dockerfile for CI testing and deployment

@MJC598 MJC598 requested a review from ddbaptiste October 2, 2024 20:02
@MJC598 MJC598 self-assigned this Oct 2, 2024
Copy link
Copy Markdown
Member

@ddbaptiste ddbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some requests for changes interspersed between general comments/questions.

Comment thread CMakeLists.txt Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread cmake/MakeDependenciesAvaliable.cmake
Comment thread tests/src/TEST_DBSource.cpp
Comment thread tests/src/TEST_DBSource.cpp
Comment thread tests/src/TEST_ModelData.cpp
@MJC598 MJC598 requested a review from ddbaptiste February 12, 2025 21:03
Copy link
Copy Markdown
Member

@ddbaptiste ddbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these last couple commits, things look great! Thanks.

Approved.

@MJC598 MJC598 merged commit 23cc548 into main Feb 12, 2025
@MJC598 MJC598 deleted the ci branch February 12, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants