[Hotfix] Copy assignment operator reference to local object error fix#109
Merged
ddbaptiste merged 1 commit intomainfrom Aug 8, 2025
Merged
[Hotfix] Copy assignment operator reference to local object error fix#109ddbaptiste merged 1 commit intomainfrom
ddbaptiste merged 1 commit intomainfrom
Conversation
MJC598
approved these changes
Aug 8, 2025
Contributor
MJC598
left a comment
MJC598
left a comment
There was a problem hiding this comment.
Ugh, thanks C++ for being annoying... Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to remove the
constmodifier from_logger_nameto make this work, since we can't use an initializer list for the copy assignment. Apparently, it's not worth the agony associated with trying to get this working while maintaining the constant qualifier here.