[Refactor] Converting Model to Interface Design#128
Merged
Conversation
ddbaptiste
requested changes
Feb 9, 2026
Member
ddbaptiste
left a comment
ddbaptiste
left a comment
There was a problem hiding this comment.
Only one change explicitly requested. The rest of this is sending out feelers for ways we can improve the code which I don't necessarily expect now but I want to think about them.
ddbaptiste
requested changes
Feb 10, 2026
Member
ddbaptiste
left a comment
ddbaptiste
left a comment
There was a problem hiding this comment.
Good catch on the state setting! Just checking on one thing that I think needs to be removed, and then I think this will be good for merging!
ddbaptiste
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pretty large refactor attempting to break the model into classes and subclasses to avoid passing functionals through pybind with Eigen values. Accompanying tests are being written too to verify behavior. There is also a slight update to the CMake to match the respondpy flow.
What Wrike task is this associated with?
Checklist before merging