Fix: Fixed sql alchemy sort mixin#32
Merged
HosseinNejatiJavaremi merged 1 commit intoSyntaxArc:masterfrom Apr 16, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes an issue in the
SqlAlchemySortMixinclass where the sorting logic did not properly handleSortOrderTypewhen it was provided as anEnum. The original code assumedsort_info.orderwas a string and directly compared it toSortOrderType.ASCENDING, which caused incorrect sorting behavior when anEnumwas passed. The updated code extracts thevaluefrom theEnum(if applicable) and compares it against thevalueofSortOrderType.ASCENDINGandSortOrderType.DESCENDING. Additionally, it introduces explicit error handling for invalidsort_info.ordervalues by raising anInvalidArgumentError.This fix ensures that sorting works correctly regardless of whether
sort_info.orderis passed as a string or anEnum, improving robustness and reliability of the sorting functionality.Fixes # (Sorting issue with Enum-based SortOrderType in SqlAlchemySortMixin)
Type of change
Checklist:
Additional context
The change was motivated by bug reports indicating that sorting failed when
SortOrderTypewas passed as anEnumin certain API endpoints. The fix maintains backward compatibility with string-based inputs while adding support forEnum-based inputs and improving error handling.