[refactor][#488] Fix permission evaluation ordering with clear rule priority #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder permission evaluation flow to ensure global rules take priority over workflow-specific permissions: 1. Global rules (deny/allow return, ask falls through) 2. Workflow auto-allow (allow returns, otherwise continue) 3. Haiku LLM (allow/deny return, ask falls through) 4. Telegram (single final escalation for ask) Key changes: - Global deny rules now always override workflow auto-allow - 'ask' results fall through sequentially to next stage - Telegram escalation unified at a single final point - Documentation updated to reflect actual evaluation order - Tests added for ordering validation Fixes #488 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
were
commented
Jan 17, 2026
Comment on lines
+9
to
+46
| ## Evaluation Order | ||
|
|
||
| Permission requests flow through these stages in order: | ||
|
|
||
| ``` | ||
| Tool Request | ||
| │ | ||
| ▼ | ||
| ┌─────────────────────────────┐ | ||
| │ 1. Global Rules │ ← First match wins (deny/allow/ask) | ||
| │ deny → DENY (stop) │ | ||
| │ allow → ALLOW (stop) │ | ||
| │ ask → fall through │ | ||
| └─────────────────────────────┘ | ||
| │ (ask or no match) | ||
| ▼ | ||
| ┌─────────────────────────────┐ | ||
| │ 2. Workflow Auto-Allow │ ← Workflow-scoped patterns | ||
| │ allow → ALLOW (stop) │ | ||
| │ none → fall through │ | ||
| └─────────────────────────────┘ | ||
| │ (no match) | ||
| ▼ | ||
| ┌─────────────────────────────┐ | ||
| │ 3. Haiku LLM │ ← Context-aware evaluation | ||
| │ deny → DENY (stop) │ | ||
| │ allow → ALLOW (stop) │ | ||
| │ ask → fall through │ | ||
| └─────────────────────────────┘ | ||
| │ (ask) | ||
| ▼ | ||
| ┌─────────────────────────────┐ | ||
| │ 4. Telegram Escalation │ ← Single final escalation | ||
| │ deny → DENY (stop) │ | ||
| │ allow → ALLOW (stop) │ | ||
| │ timeout → ASK (prompt) │ | ||
| └─────────────────────────────┘ | ||
| ``` |
Contributor
Author
There was a problem hiding this comment.
Why don't you make this a rich text mermaid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the permission evaluation order to ensure global rules take priority over workflow-specific permissions, with clear fall-through behavior and unified Telegram escalation. The previous implementation allowed workflow auto-allow to bypass global deny rules, which was a security concern.
Changes
.claude-plugin/lib/permission/determine.py:435-491to reorder evaluation flow:docs/feat/permissions/rules.mdwith explicit evaluation order diagram and stage documentationdocs/feat/permissions/telegram.mdto clarify Telegram as the final escalation pointdocs/feat/core/handsoff.mdto correct hook location and permission module pathstests/cli/test-hook-permission-matching.sh:317-433with 4 new ordering tests:tests/fixtures/test-pre-tool-use-input.jsonwith ordering test fixturesTesting
Related Issue
Closes #488