Conversation
To identify reversible reactions, look at LB<0 instead of model.rev.
Do not use usage_prot reactions as sample objectives
|
This PR has been automatically tested with GH Actions. Here is the output of the tests: > Installation type Advanced (via git)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
importModelprevent colon operands warningrandomSamplinguses real reaction bounds and not themodel.revfield to identify reversible reactions, and filters from goodRxns those reactions that cannot carry fluxsetParamchecks if the new LB and UB values are not invalidrandomSamplingrecognizes if a model is a GECKO v3+ ecModel, in which case the usage_prot reactions are not sampledimportModelparsing of LB and UB values, minor speed improvementsgetMILPParams, which has been obsolete since 2.7.10Instructions on merging this PR:
developas target branch, and will be resolved with a squash-merge.mainas target branch, and will be resolved as descriped here.