Skip to content

Conversation

@mrvnklm
Copy link

@mrvnklm mrvnklm commented Aug 1, 2023

to add the possibility to upload files to exisiting vouchers by just adding the voucher id

file()->upload(string $filepath, string $type, ?string $voucherId = null)

to add the possibility to upload files to exisiting vouchers by just adding the voucher id

`file()->upload(string $filepath, string $type, ?string $voucherId = null)`
@Sysix
Copy link
Owner

Sysix commented Dec 7, 2023

Hello @mrvnklm

thanks for the PR. 2 things are bugging me:

  1. The Client refers to 2 Endpoints, We have already a Client/Voucher which should be the prefered Place
  2. The $type Parameter is not required for the endpoint

I implemented a new method for the next major release: fbdbfdc

@Sysix Sysix mentioned this pull request Dec 7, 2023
Merged
8 tasks
@Sysix Sysix closed this in #130 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants