Security hardening: URL encoding, SAS state isolation, JWT validation#8
Merged
System-Admins-ath merged 2 commits intomainfrom Feb 20, 2026
Merged
Conversation
…tion, JWT validation Co-authored-by: System-Admins-ath <94194707+System-Admins-ath@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review code base for issues and security vulnerabilities
Security hardening: URL encoding, SAS state isolation, JWT validation
Feb 20, 2026
System-Admins-ath
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codebase audit found several security issues and a state corruption bug in the SAS URL preview flow.
Security fixes
ARM API path injection —
subscriptionId,resourceGroup,accountNameinterpolated raw into REST URL paths. Added_encArmSegment()wrapper usingencodeURIComponenton all ARM URL path segments.URL hash encoding — App link construction used
#${item.name}without encoding, breaking URLs with special characters. Now usesencodeURIComponent.JWT structure validation —
_parseJwt()blindly split and decoded without checking 3-part structure or that the payload is a non-null object.State corruption fix
_showOpenSasModalcalledactivateSasMode()on every keystroke to preview SAS URL metadata, temporarily corruptingCONFIG.storageand_SAS_STATE. Extracted a pureparseSasUrl()function that returns parsed metadata without side effects.activateSasMode()now delegates to it internally.Code quality
_showInfoModal'saddRow()— usestextContentby default,innerHTMLonly when explicitly passing trusted HTML.console.warnto metadata fetch failures in edit/upload flows.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.