Conversation
rbuergi
added a commit
that referenced
this pull request
May 5, 2026
…istent Tasks #3, #4, #29 from the failing-tests list. 1. MeshDataSource.StartCompile no longer calls nodeTypeService.InvalidateCache(hubPath) after a successful compile. Each compile produces a fresh timestamp-keyed AssemblyLoadContext under {cacheDir}/{nodeName}_{ticks_hex}/ — V1 and V2 ALCs coexist happily. The InvalidateCache path called cacheService.InvalidateCache, which unloads every ALC matching the NodeName — including the V2 ALC we'd just created. Next consumer (instance2's per-node hub asking the NodeType hub for HubConfiguration via GetCompilationPathRequest) raced the AssemblyLoadContext.Unload window and fell back to the previous release's lambda, so instance2 served V1 markup after a V2 recompile. NodeTypeContractHandler resolves AssemblyLocation directly off the post-compile MeshNode anyway — there's no NodeTypeService cache that needs flushing. 2. ApiTokenService.DeleteToken returns false early when the index lookup doesn't find the token node. Previously it fell through to nodeFactory.DeleteNode(path), which throws InvalidOperationException ("Node not found: …") in MeshService.DeleteNode for missing paths. Same shape as RevokeToken (which already returned false for absent). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.