feat: match reference argon2 CLI output and zeroize password#4
Merged
Conversation
- Hex-encode `-r` raw output to match reference `argon2` binary - Read stdin verbatim to preserve trailing and inner newlines - Verify password with `verify_password()` before "Verification ok" - Wrap password in `Zeroizing` to clear it from memory on drop - Propagate input-read errors with `?` instead of `process::exit` - Add reference-compatibility tests for `-e`, `-r`, and stdin handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-rraw output to match referenceargon2binaryverify_password()before "Verification ok"Zeroizingto clear it from memory on drop?instead ofprocess::exit-e,-r, and stdin handling