Conversation
hiergaut
commented
Mar 21, 2024
- [cmake] Update cppcheck target
- need cppcheck passed without error
|
I am splitting this branch to separate old server implement removing from this feature branch, please do not merge this branch until process done. |
|
Splitted, waiting now for #16 merged. |
bc846e2 to
bd6138e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Not ready, some tests failed |
|
tests passed, @nmellado this PR is ready to merge |
|
I've cleaned the history. Question: why removing mqtt tests in this PR ? |
|
this cmake line |
|
Can I do the commit name change ? |
nmellado
left a comment
There was a problem hiding this comment.
this cmake line
list(FILTER test_srcs EXCLUDE REGEX ".*Mqtt\\.cpp$")did the job. It removed Mqtt test if Mqtt library not found The lines I commented are useless now because I use one directory per src module We can rename the commit "Disable Mqtt tests" -> "Removed useless mqtt cmake removal"
Ok, makes sense.
Please :
- reword commit message as "[cmake] Remove dead code"
- in cmake, remove lines instead of commenting out
- in CHANGELOG, add entry [cmake] Remove dead code (#15)
|
@nmellado this PR is ready to merge |