task/WG-594 improve db connections #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create ONE shared engine/pool for all Celery tasks via get_celery_engine() - Add application_name to connection strings for monitoring - Rename engine to migrate_engine for clarity
Added in #248 but not used there.
nathanfranklin
changed the title
WebSocket connections stay open longer which was causing DB sessions in auth handlers to leak. (HTTP requests were fine because the autocommit approach was cleaning things up correctly). Now, added a context manager to explicitly commit and close DB sessions. Some is overkill as the autocommit for HTTP requests is fine but adding the context manager anyway just to be consistent and in case they're ever used in WebSocket routes.
rstijerina
approved these changes
Oct 30, 2025
This reverts commit c7a5fdf.
…/geoapi into hotfix/improve-db-connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR works on changes for our db connections as no connections available error on prod is occuring.
Add shorter WebSocket timeout for local dev so restart occurs during changeNote: hot restart might just be workign as we no longer have astale in transactionconnectionBackground info
max_connections = 200on database (see here)Related Jira tickets:
Testing Steps: