refactor: figure & blockquote, @mixin not @extend#1135
Merged
wesleyboar merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Use figure and blockquote styles form Core-Styles via
@mixinnot@extend.Important
Install Core-Styles at version after releasing TACC/Core-Styles#612
Related
Changes
@extend .x-figureto@mixin figureTesting
Build CSS for
mainand this branch such that you can compare diff:Verify unstaged diff of
taccsite_cms/static/site_cms/css/build/figure-caption-blockquote.csslooks similar to diff of refactor: convert x-figure & x-blockquote to mixins Core-Styles#612dist/elements/html-elements.docs.css.Stage the diff of new build:
Copy diff of refactor: convert x-figure & x-blockquote to mixins Core-Styles#612
dist/elements/html-elements.docs.cssintotaccsite_cms/static/site_cms/css/build/figure-caption-blockquote.css.Verify diff is just the new selectors in
taccsite_cms/static/site_cms/css/src/_imports/elements/figure-caption-blockquote.cssand the unique rule at the bottom of it.UI
Skipped.
I will do manual integration test via TACC/tup-ui#537. This is belated housekeeping to allow me to properly fix illegible caption on https://tacc.utexas.edu/use-tacc/visualization-services/.