Skip to content

refactor: figure & blockquote, @mixin not @extend#1135

Merged
wesleyboar merged 1 commit intomainfrom
refactor/use-figure-and-blockquote-mixins-bot-extend
Mar 26, 2026
Merged

refactor: figure & blockquote, @mixin not @extend#1135
wesleyboar merged 1 commit intomainfrom
refactor/use-figure-and-blockquote-mixins-bot-extend

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Mar 26, 2026

Overview

Use figure and blockquote styles form Core-Styles via @mixin not @extend.

Important

Install Core-Styles at version after releasing TACC/Core-Styles#612

Related

Changes

  • updates Core-Styles
  • changes @extend .x-figure to @mixin figure

Testing

  1. Build CSS for main and this branch such that you can compare diff:

    git checkout main
    git pull
    npm ci
    npm run build:css
    git add -f taccsite_cms/static/site_cms/css/build
    gco refactor/use-figure-and-blockquote-mixins-bot-extend
    git pull
    npm ci
    npm run build:css
  2. Verify unstaged diff of taccsite_cms/static/site_cms/css/build/figure-caption-blockquote.css looks similar to diff of refactor: convert x-figure & x-blockquote to mixins Core-Styles#612 dist/elements/html-elements.docs.css.

  3. Stage the diff of new build:

    git add -f taccsite_cms/static/site_cms/css/build
  4. Copy diff of refactor: convert x-figure & x-blockquote to mixins Core-Styles#612 dist/elements/html-elements.docs.css into taccsite_cms/static/site_cms/css/build/figure-caption-blockquote.css.

  5. Verify diff is just the new selectors in taccsite_cms/static/site_cms/css/src/_imports/elements/figure-caption-blockquote.css and the unique rule at the bottom of it.

UI

Skipped.

I will do manual integration test via TACC/tup-ui#537. This is belated housekeeping to allow me to properly fix illegible caption on https://tacc.utexas.edu/use-tacc/visualization-services/.

@wesleyboar wesleyboar marked this pull request as ready for review March 26, 2026 20:01
@wesleyboar wesleyboar merged commit 6e7f4bc into main Mar 26, 2026
@wesleyboar wesleyboar deleted the refactor/use-figure-and-blockquote-mixins-bot-extend branch March 26, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant