Skip to content

Task/gh 171 support css that is forwards compatible#173

Merged
wesleyboar merged 5 commits intomainfrom
task/GH-171-support-css-that-is-forwards-compatible
Apr 9, 2021
Merged

Task/gh 171 support css that is forwards compatible#173
wesleyboar merged 5 commits intomainfrom
task/GH-171-support-css-that-is-forwards-compatible

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Mar 30, 2021

Overview

  1. Add plugin postcss-preset-env to support forward-compatible CSS.
  2. Support urgent-need features:
  3. Do not remove duplicate CSS i.e. do not sweep bad CSS under the rug.

Related Issues

Testing

  1. Run npm ci to clean install node dep's.
  2. Run npm run build to build CSS, including a plugin test file.
  3. Open taccsite_cms/static/site_cms/css/build/_test.css.
  4. Ensure output matches what the files reports the output should be.

@wesleyboar wesleyboar requested a review from taoteg March 30, 2021 04:04
This was referenced Mar 30, 2021
@wesleyboar wesleyboar linked an issue Mar 30, 2021 that may be closed by this pull request
@wesleyboar wesleyboar removed the request for review from taoteg April 2, 2021 10:17
@wesleyboar wesleyboar added the priority ━ Medium priority label Apr 6, 2021
Copy link
Copy Markdown
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes

Comment thread conf/css/postcss.config.js
Comment thread conf/css/postcss.config.js
Copy link
Copy Markdown
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@wesleyboar wesleyboar merged commit 7d4ee06 into main Apr 9, 2021
@wesleyboar wesleyboar deleted the task/GH-171-support-css-that-is-forwards-compatible branch April 9, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority ━ Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Forward-Compatible CSS

2 participants