FP-1410: Shrink Guide Images & Add Links to Open in New Tab#462
Merged
wesleyboar merged 2 commits intomainfrom Mar 11, 2022
Merged
FP-1410: Shrink Guide Images & Add Links to Open in New Tab#462wesleyboar merged 2 commits intomainfrom
wesleyboar merged 2 commits intomainfrom
Conversation
wesleyboar
commented
Mar 10, 2022
Member
Author
wesleyboar
left a comment
There was a problem hiding this comment.
Comments for reviewers.
(also, remove redundant code)
25d8824 to
49ac733
Compare
edmondsgarrett
approved these changes
Mar 11, 2022
Contributor
edmondsgarrett
left a comment
There was a problem hiding this comment.
LGTM! Images are appropriate size for wide & narrow windows, and behave as otherwise described in testing steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Related
Changes
<a>'sTesting
Screenshots
Data Transfer Guide
576px
992px
1680px
Globus Data Transfer Guide
576px
992px
1680px
Footnotes
If testing locally, you'll need to create those two pages. To put content on them, choose the correct page template, which are best to define in the
settings_custom.py. Example:('guides/data_transfer.globus.html', 'Guide: Globus Data Transfer'). ↩At some widths (992px or 576px depending on the page), images are larger than before. That's okay—they were too small on mobile for narrow screens, and Design likes images on mobile to take up all of page width (unless its some intentionally small image). What I did was pick a max size for these guides' images that offered legibility without being too large. At a much wider width, the images are definitely smaller than before. ↩