feat: add djangocms_tacc_image_gallery#654
Merged
wesleyboar merged 11 commits intomainfrom Jun 20, 2023
Merged
Conversation
I removed assumption that tacc/core-styles would be used for styling.
Member
Author
|
This will be installed into https://github.com/TACC/tup-ui instead, and only into each CMS as needed, because it is as simple as a plugin install. |
Member
Author
|
Crap. I don't know how to install only in one CMS. The other CMS's do not have their own |
Member
Author
|
Okay, as of b435eb3, the install is from |
This was referenced Jun 15, 2023
- supports link plugins and image link attributes - fixes link title (from image alt)
4 tasks
Member
Author
|
I merge based on approval and merge (and upcoming deploy) of use in initial client, tup-ui, in TACC/tup-ui#232. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add
djangocms_tacc_image_galleryvia https://github.com/wesleyboar/Core-CMS-Plugin-Image-Gallery.Related
Changes
Testing
How to Create Gallery
<script>to loadinitialize.jsis in markup only once<link>to loadgallery.cssis in markup only onceHow to Use Gallery
How to Review Gallery
<script>to loadinitialize.jsis in markup only once<link>to loadgallery.cssis in markup only onceon https://github.com/TACC/tup-ui
via Django CMS QuickStart
via https://github.com/TACC/Core-CMS
UI
Notes
The plugin does not have database migrations.
An alternative solution (with drawbacks) is built at https://dev.tup.tacc.utexas.edu/test/image-gallery/.
The drawbacks are disparate pieces and extra manual steps for each gallery.
s-image-grid,lightboxgallery