Skip to content

enhance: improve admin UI permissions error text#693

Merged
wesleyboar merged 4 commits intomainfrom
enhance/improve-admin-ui-text-for-missing-edit-perm
Aug 22, 2023
Merged

enhance: improve admin UI permissions error text#693
wesleyboar merged 4 commits intomainfrom
enhance/improve-admin-ui-text-for-missing-edit-perm

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Aug 21, 2023

Overview

Improve confusing text error message in the Django CMS Admin UI.

Related

None.

Backstory

When trying to give staff member Publish permission on ECEP, I hit confusing error message.

I got angry at Django CMS. I thought about proposing better error text on Django CMS proper. Then I realized I don't know if I should edit their msgstr in their en po file, or just change in my own app. I remembered how much all of Django CMS text sucks, but also how unfamiliar I am with what most of it means, and did not trust myself to improve Django CMS at the source. Especially, because I am out-of-date with their interface (we run older version of their software).

Changes

  • changed four error messages.

Testing

  1. Open http://0.0.0.0:8000/admin/cms/globalpagepermission/add/.
  2. For any Group or User, give/check only the permission "Can publish".

UI

before after
user perm text - before user perm text - after

@wesleyboar wesleyboar changed the title enhance: improve admin UI text for missing perm enhance: improve admin UI permissions error text Aug 21, 2023
Copy link
Copy Markdown
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Clearer action for users.

@wesleyboar wesleyboar merged commit 7448d9d into main Aug 22, 2023
@wesleyboar wesleyboar deleted the enhance/improve-admin-ui-text-for-missing-edit-perm branch August 22, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants