fix: ui demo for core and clients#706
Merged
wesleyboar merged 14 commits intomainfrom Aug 28, 2023
Merged
Conversation
And do some minor cleanup of demo configuration.
BREAKING CHANGE: Clients expecting UI demo will not have it now.[^1][^2] [^1]: Only 2 clients expected it: core-cms, tup-ui. I'll prepare them. [^2]: UI demo is already broken as of v3.12.0-beta.2.
This reverts commit 480b43b.
This reverts commit bed395e.
wesleyboar
changed the title
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Aug 28, 2023
This fix is needed to get TUP out of alpha. TACC/Core-CMS#706
wesleyboar
deleted the
fix/ensure-ui-demo-works-on-core-and-client-and-is-simpler
branch
jarosenb
pushed a commit
to TACC/tup-ui
that referenced
this pull request
Sep 5, 2023
* fix: demo-ui fix in v3.12.0-beta This fix is needed to get TUP out of alpha. TACC/Core-CMS#706 * fix: official v3.12.0-beta.3 release https://github.com/TACC/Core-CMS/releases/tag/v3.12.0-beta.3 Diff since last commit saved: TACC/Core-CMS@cbe7d71...v3.12.0-beta.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview / Changes
For UI Demo:
Because fix: serve ui demo if it exists #692 did not seem to fix it on TUP.
Because it wasn't working and was convoluted.
ui-demoIt had been
css-demo, but it could demo JavaScript.Related
Testing
UI