fix: tup-639 move c-button font-weight bold to cms#740
Merged
wesleyboar merged 4 commits intomainfrom Nov 3, 2023
Merged
Conversation
wesleyboar
changed the title
wesleyboar
changed the title
R-Tomas-Gonzalez
approved these changes
Nov 3, 2023
Contributor
R-Tomas-Gonzalez
left a comment
R-Tomas-Gonzalez
left a comment
There was a problem hiding this comment.
Looks good to me.
• Tested on Core-CMS and TUP-UI, no side effects
• Looks like a simple change, migrated from tup-ui -> core-styles (then deleted) -> to core-cms
Member
Author
|
Ideally, this PR also loads a new version of Core-Styles that includes TACC/Core-Styles#253. But, I don't wanna update Core-Styles version from 2.11 to 2.19 not fully tested for all those changes just to avoid (a) some extra CSS and (b) not-yet-bold text. I'll update Core-CMS's version of Core-Styles in isolation just after merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
All
c-buttonfont-weight bold to CMS.Related
Changes
Testing & UI
See TACC/tup-ui#364.