Update dockerfile to speed up builds

[jarosenb]

Overview

Update the Dockerfile to remove Node deprecation warnings in CI and streamline Python dependency installation

Related

• WI-63

Changes

• Use a separate Node build step to handle style building
• Update Poetry config to use the container's system Python
• expose the Poetry binary when Core-CMS is used as a base image.

[wesleyboar]

Looks good.

(As a separate task) Would it be inappropriate to run python manage.py collectstatic via the Dockerfile? I think this might save devs¹ and CI that step in client apps.

Answer
[It] makes sense for collectstatic to happen downstream. Static files need to live in a volume that's shared with the Nginx container. IDK if that setup works if they're baked into the container. Also anything that uses core-cms as a base image will need to run collectstatic again anyway. e.g. tup needs to do it to pick up tup-ui.

---

Also, I should test this PR thoroughly.

• Core-CMS local
• Core-CMS remote
• Core-CMS-Resources local
• Core-CMS-Resources remote
• Core-CMS-Custom local
• Core-CMS-Custom remote
• tup-ui local (I have a clone)
• tup-ui remote

Footnotes

1. The collectstatic might be unnecessary for devs, if they have DEBUG set to True, because urls.py#L82-L83 (since 1c326b9).² ↩

2. 2023-01-16: v4.4.1 README suggests devs might still need to run collectstatic. ↩

[taoteg]

LGTM! Nice update.

[wesleyboar]

I think I understand this well now. Based on my understanding, I tested enough.