Skip to content

hotfix: restore margin-bottom for narrow-screen blog images#759

Merged
wesleyboar merged 1 commit intomainfrom
hotfix/restore-margin-bottom-for-narrow-screen-blog-images
Dec 11, 2023
Merged

hotfix: restore margin-bottom for narrow-screen blog images#759
wesleyboar merged 1 commit intomainfrom
hotfix/restore-margin-bottom-for-narrow-screen-blog-images

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Dec 11, 2023

Overview

The left- and right-aligned images were missing the margin-bottom that a center-aligned image had.

@wesleyboar found no reason for this.

Related

Changes

  • removed unset of margin-bottom

Testing

  1. Have a CMS with Blog/News.
  2. Load a blog article with left-aligned, center-aligned, and right-aligned image.

UI

left center right
left center right

The left- and right-aligned images were missing the margin-bottom that a center-aligned image had. I found no reason for this. Noticed in #756.
wesleyboar added a commit to TACC/Core-Styles that referenced this pull request Dec 11, 2023
The left- and right-aligned images had a margin-bottom that a center-aligned image had not. I found no reason for this. Noticed in TACC/Core-CMS#759.
@wesleyboar wesleyboar marked this pull request as ready for review December 11, 2023 21:05
@wesleyboar wesleyboar merged commit b57e5f7 into main Dec 11, 2023
@wesleyboar wesleyboar deleted the hotfix/restore-margin-bottom-for-narrow-screen-blog-images branch December 11, 2023 21:06
wesleyboar added a commit to TACC/Core-Styles that referenced this pull request Dec 11, 2023
The left- and right-aligned images had a margin-bottom that a center-aligned image had not. I found no reason for this. Noticed in TACC/Core-CMS#759.
wesleyboar added a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant