Skip to content

task/tup-557 Fixes drop cap articles for Core-CMS#775

Merged
wesleyboar merged 5 commits intomainfrom
task/tup-557-drop-cap-articles
Dec 20, 2023
Merged

task/tup-557 Fixes drop cap articles for Core-CMS#775
wesleyboar merged 5 commits intomainfrom
task/tup-557-drop-cap-articles

Conversation

@R-Tomas-Gonzalez
Copy link
Copy Markdown
Contributor

@R-Tomas-Gonzalez R-Tomas-Gonzalez commented Dec 14, 2023

Overview

Fixes drop cap articles for Core-CMS

Related

Changes

Quick fix, changes css to initial-letter. NOTE. This will not work on Firefox at the time of developing.

Testing

  1. Check http://localhost:8000/static/ui/components/detail/s-drop-cap.html on different browsers. Currently works for chromium and safari.

UI

safari
Screenshot 2023-12-14 at 4 47 05 PM
chrome
Screenshot 2023-12-14 at 4 47 27 PM

@R-Tomas-Gonzalez R-Tomas-Gonzalez added priority ▼ Low priority effort XS Extra small effort task (~¼ a week) — does not include review time labels Dec 14, 2023
@R-Tomas-Gonzalez R-Tomas-Gonzalez self-assigned this Dec 14, 2023
Comment thread taccsite_cms/static/site_cms/css/src/_imports/tools/x-drop-cap.css Outdated
Comment thread taccsite_cms/static/site_cms/css/src/_imports/tools/x-drop-cap.css Outdated
Comment thread taccsite_cms/static/site_cms/css/src/_imports/tools/x-drop-cap.css Outdated
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I'll test and approve today or Monday.

Comment thread taccsite_cms/static/site_cms/css/src/_imports/trumps/s-drop-cap.css Outdated
Comment thread taccsite_cms/static/site_cms/css/src/_imports/trumps/s-drop-cap.css Outdated
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one thing while testing.

Comment thread taccsite_cms/static/site_cms/css/src/_imports/trumps/s-drop-cap.css Outdated
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved.

@wesleyboar wesleyboar merged commit 3883194 into main Dec 20, 2023
@wesleyboar wesleyboar deleted the task/tup-557-drop-cap-articles branch December 20, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort XS Extra small effort task (~¼ a week) — does not include review time priority ▼ Low priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants