Skip to content

Task/tup-671 News Article Drop-Cap#777

Merged
wesleyboar merged 3 commits intomainfrom
task/tup-671-news-article-drop-cap
Dec 21, 2023
Merged

Task/tup-671 News Article Drop-Cap#777
wesleyboar merged 3 commits intomainfrom
task/tup-671-news-article-drop-cap

Conversation

@R-Tomas-Gonzalez
Copy link
Copy Markdown
Contributor

Overview

Adds drop-cap to news articles

Related

Changes

  • Added s-drop-cap to the blog-content div class

Testing

  1. Create a new article in your local environment
  2. You may have to deactivate a couple of styles to see this take effect
    a. Remove empty paragraph in blog-content div
    Screenshot 2023-12-20 at 5 38 45 PM
    b. Remove the blog-visual div
    Screenshot 2023-12-20 at 5 39 59 PM

UI

Drop-Cap in News Article
Screenshot 2023-12-20 at 5 26 46 PM

Notes

Accidentally messed up the commits. But the final commit just adds in the s-drop-cap class to the blog-content div

@R-Tomas-Gonzalez R-Tomas-Gonzalez self-assigned this Dec 20, 2023
@R-Tomas-Gonzalez R-Tomas-Gonzalez added priority ▼ Low priority effort XS Extra small effort task (~¼ a week) — does not include review time labels Dec 20, 2023
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. That's all I think is necessary. I'll test tomorrow.

@wesleyboar wesleyboar merged commit b8bb40d into main Dec 21, 2023
@wesleyboar wesleyboar deleted the task/tup-671-news-article-drop-cap branch December 21, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort XS Extra small effort task (~¼ a week) — does not include review time priority ▼ Low priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants