Task/TUP-702 Make new windows accessible#803
Merged
wesleyboar merged 7 commits intomainfrom Feb 22, 2024
Merged
Conversation
wesleyboar
requested changes
Feb 20, 2024
Member
wesleyboar
left a comment
There was a problem hiding this comment.
Please,
-
Un-commit migration files.
You may delete the migrations from your local server.
-
Undo unrelated formatting changes, so diff is clear.
Let's figure out what code editor settings are causing this. Maybe your code editor is (appropriately) using the Core-CMS
.editorconfig, and I need to format the whole repo to match or something.
This reverts commit f6ba458.
Contributor
Author
Fixed |
wesleyboar
reviewed
Feb 21, 2024
wesleyboar
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Creates accessibility for external links
Related
Changes
target="_blank", so let's addaria-description='Opens in new window.'Testing
aria-descriptionattribute andrel=noopenerUI