Skip to content

Task/TUP-702 Make new windows accessible#803

Merged
wesleyboar merged 7 commits intomainfrom
task/TUP-702-make-new-windows-accessible
Feb 22, 2024
Merged

Task/TUP-702 Make new windows accessible#803
wesleyboar merged 7 commits intomainfrom
task/TUP-702-make-new-windows-accessible

Conversation

@R-Tomas-Gonzalez
Copy link
Copy Markdown
Contributor

@R-Tomas-Gonzalez R-Tomas-Gonzalez commented Feb 20, 2024

Overview

Creates accessibility for external links

Related

Changes

  • New windows are not inherently accessible
  • We dynamically set the attribute of target="_blank", so let's add aria-description='Opens in new window.'

Testing

  1. Add an external link
  2. Make sure link has aria-description attribute and rel=noopener

UI

Screenshot 2024-02-19 at 4 37 23 PM

@R-Tomas-Gonzalez R-Tomas-Gonzalez added effort XS Extra small effort task (~¼ a week) — does not include review time javascript labels Feb 20, 2024
@R-Tomas-Gonzalez R-Tomas-Gonzalez self-assigned this Feb 20, 2024
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please,

  1. Un-commit migration files.

    You may delete the migrations from your local server.

  2. Undo unrelated formatting changes, so diff is clear.

    Let's figure out what code editor settings are causing this. Maybe your code editor is (appropriately) using the Core-CMS .editorconfig, and I need to format the whole repo to match or something.

@R-Tomas-Gonzalez
Copy link
Copy Markdown
Contributor Author

Please,

  1. Un-commit migration files.
    You may delete the migrations from your local server.
  2. Undo unrelated formatting changes, so diff is clear.
    Let's figure out what code editor settings are causing this. Maybe your code editor is (appropriately) using the Core-CMS .editorconfig, and I need to format the whole repo to match or something.

Fixed

Comment thread taccsite_cms/static/site_cms/js/modules/setTargetForExternalLinks.js Outdated
@wesleyboar wesleyboar merged commit 1ee0e9d into main Feb 22, 2024
@wesleyboar wesleyboar deleted the task/TUP-702-make-new-windows-accessible branch February 22, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort XS Extra small effort task (~¼ a week) — does not include review time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants