Skip to content

fix: WP-602 docker compose with and without dash#858

Merged
wesleyboar merged 1 commit intomainfrom
fix/WP-602-makefile
Aug 7, 2024
Merged

fix: WP-602 docker compose with and without dash#858
wesleyboar merged 1 commit intomainfrom
fix/WP-602-makefile

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Aug 7, 2024

Overview

Docker v2 has different command for docker compose. Adjust Makefile to handle both based on availability.

Related

Changes

  • added conditional docker compose command to Makefile
  • changed docker-compose to docker compose in README

Testing

  1. make build — no error firing command from Makefile
  2. make start — no error firing command from Makefile

UI

Skipped.

@wesleyboar
Copy link
Copy Markdown
Member Author

Still open to review. I'll propagate improvements that arise.

Copy link
Copy Markdown
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wesleyboar
Copy link
Copy Markdown
Member Author

wesleyboar commented Aug 7, 2024

We discussed hard-coding docker compose. The old command (docker-compose) has been deprecated for years, but I'm tempted to keep Core-CMS backwards-compatible until v5.

Details

Hard-coding the new command would be a backwards-incompatible change for Core-*, thus technically forcing a Core-CMS v5. There was unofficial agreement to tie Core-CMS major versions to Django v5. I'll add a comment to flag docker-compose support as deprecated.

P.S. Example: All the settings changes have been backwards-compatible (settings.py, upgrade-project.py).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants