fix: WP-602 docker compose with and without dash#858
Merged
wesleyboar merged 1 commit intomainfrom Aug 7, 2024
Merged
Conversation
chandra-tacc
approved these changes
Aug 7, 2024
Member
Author
|
Still open to review. I'll propagate improvements that arise. |
Member
Author
|
We discussed hard-coding DetailsHard-coding the new command would be a backwards-incompatible change for Core-*, thus technically forcing a Core-CMS v5. There was unofficial agreement to tie Core-CMS major versions to Django v5. I'll add a comment to flag P.S. Example: All the settings changes have been backwards-compatible ( |
This was referenced Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Docker v2 has different command for
docker compose. Adjust Makefile to handle both based on availability.Related
docker composewith and without dash Core-CMS-Custom#301Changes
docker composecommand to Makefiledocker-composetodocker composein READMETesting
make build— no error firing command from Makefilemake start— no error firing command from MakefileUI
Skipped.