Skip to content

refactor: define title block only in base#883

Merged
wesleyboar merged 2 commits intomainfrom
chore/no-need-to-redefine-title-block
Oct 2, 2024
Merged

refactor: define title block only in base#883
wesleyboar merged 2 commits intomainfrom
chore/no-need-to-redefine-title-block

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Oct 2, 2024

Overview

Set {% block title %} properly in base.html, not other templates.

Important

Zero files changed cuz I accidentally committed to main (5e88521).

Related

Changes

  • changed block in base.html template
  • removed now-redundant block from other templates

Testing

  1. Verify page <title> equals "Page Title" or "Title" of page.
  2. Check page/s with different template/s.

UI

Skipped.

@wesleyboar wesleyboar changed the title Chore/no need to redefine title block refactor: define title block only in base Oct 2, 2024
@wesleyboar wesleyboar merged commit f74e0d5 into main Oct 2, 2024
@wesleyboar wesleyboar deleted the chore/no-need-to-redefine-title-block branch October 2, 2024 18:43
@wesleyboar wesleyboar restored the chore/no-need-to-redefine-title-block branch October 2, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant