fix: nav alignment fix too complex (simplify PR #427)

[wesleyboar]

Overview

Simplify nav alignment fix from #427.

^{Improvements come from lessons learned during TACC/Core-CMS#909.}

Related

• simplifies fix: s-header nav-link alignment inconsistent #427
• mimics fix: CMS nav link alignment (retrofit to Core-Styles v0) Core-CMS#909

Changes

• added variable for .nav-link border width
  ^{Useful for testing it in calculations, but ultimately not used.}
• removed positioning of .nav-link
• changed height calculation of .nav-link

Testing

1. Open Core-Styles v2 CMS website e.g. https://cep.tacc.utexas.edu/.
2. Live edit the styles.
   • add these styles

     .portal-logo { height: 60px; }
     .s-header .navbar-brand { min-width: unset; }

   • replace Core-CMS core-styles.header.css content with …https://cdn.jsdelivr.net/gh/TACC/Core-Styles@29b12800/dist/core-styles.header.css
3. Verify nav links are still horizontally-aligned center in nav.
4. Verify active/hover nav links border is exactly at bottom of header.

UI

before	after