Skip to content

refactor: simple explicit header nav link padding#462

Merged
wesleyboar merged 5 commits intomainfrom
refactor/simple-explicit-header-nav-link-padding
Mar 1, 2025
Merged

refactor: simple explicit header nav link padding#462
wesleyboar merged 5 commits intomainfrom
refactor/simple-explicit-header-nav-link-padding

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Mar 1, 2025

Overview

  • Simplify header nav link padding styles.
  • Make header nav link padding consistent.
    (i.e. overwrite Bootstrap's rem, which causes different space per client)

Related

Changes

  • renamed mixin from header__nav-link--tall to header--not-expanded
  • added absolute sizes for dropdown padding
  • scoped two styles to .s-header.

Testing & UI

  • Menu has zero change from before, especially .nav-link padding.
  • Menu has greater padding block when expanded.
not expanded is expanded
menu not expanded menu is expanded

@wesleyboar wesleyboar merged commit 85ebf82 into main Mar 1, 2025
@wesleyboar wesleyboar deleted the refactor/simple-explicit-header-nav-link-padding branch March 1, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant