Skip to content

fix: cortal.icon fails to load on built demo#482

Merged
wesleyboar merged 1 commit intomainfrom
fix/cortal-icon-inaccessible-on-built-demo
Mar 6, 2025
Merged

fix: cortal.icon fails to load on built demo#482
wesleyboar merged 1 commit intomainfrom
fix/cortal-icon-inaccessible-on-built-demo

Conversation

@wesleyboar
Copy link
Copy Markdown
Member

@wesleyboar wesleyboar commented Mar 6, 2025

Overview / Changes

Rename* cortal.icon to cortal-icon.

* Backwards-compatible.

Related

Testing

  1. Run npm run build:demo && npx serve demo.
  2. Visit Patterns > Components > Icon (Cortal).
  3. Verify URL is http://localhost:3000/components/detail/cortal-icon.
  4. Verify page loads icons.

UI

See #447.

but portal-icon would, so I made that
@wesleyboar wesleyboar merged commit 516b43b into main Mar 6, 2025
@wesleyboar wesleyboar deleted the fix/cortal-icon-inaccessible-on-built-demo branch March 6, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant